nullobsi
/
ipfs-upload
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove some excess debug statements and use warn instead of say where needed. 

Also fix 401 unauthorized error on non owned pins.
This commit is contained in:
Citlali del Rey 2022-11-11 17:33:38 -08:00
parent 2c42321837
commit 675faa600c
Signed by: nullobsi
GPG Key ID: 933A1F44222C2634
2 changed files with 6 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/IpfsUpload/Controller/Interface.pm
View File

@ -123,7 +123,6 @@ sub del_pin($c) {
# I wonder if this could cause a race condition.
# Who cares!
my $cid = $pin->{cid};
say $cid;
return $c->pins->cid_count($cid)->then(sub ($count) {
if ($count == 1) {
@ -213,7 +212,7 @@ sub upload_post($c) {
});
} else {
# TODO: read error and use appropriate response
say $res->body;
warn $res->body;
die "Failed to pin.";
}
})->then(sub ($res) {
@ -294,7 +293,7 @@ sub import_post ($c) {
});
} else {
# TODO: read error and use appropriate response
say $res->body;
warn $res->body;
die "Failed to pin.";
}
})->then(sub($res) {

19
lib/IpfsUpload/Controller/Pins.pm
View File

@ -105,7 +105,8 @@ sub get($c) {
my $id = $c->param('requestid');
return $c->pins->get({
id => $id,
uid => $uid,
id => $id,
})->then(sub ($pin) {
if (!defined $pin) {
return $c->render(status => 404, openapi => {
@ -116,16 +117,6 @@ sub get($c) {
})
}
# TODO: Should any pin be accessible to the public?
if ($pin->{uid} ne $uid) {
return $c->render(status => 401, openapi => {
error => {
reason => "UNAUTHORIZED",
details => "You cannot view that pin.",
},
});
}
return $c->render(status => 200, openapi => {
requestid => $pin->{id},
# TODO
@ -241,7 +232,7 @@ sub replace($c) {
});
} else {
# TODO: read error and use appropriate response
say $res->body;
warn $res->body;
die "Failed to pin.";
}
})->then(sub($res) {
@ -253,7 +244,6 @@ sub replace($c) {
return $c->pins->cid_count($pin->{cid});
})->then(sub($count) {
# Zero this time, since we already replaced the DB entry.
say "Count: $count";
if ($count == 0) {
my $url = Mojo::URL->new($c->config->{ipfs}->{gatewayWriteUrl});
$url->path("api/v0/pin/rm");
@ -311,7 +301,6 @@ sub delete($c) {
# I wonder if this could cause a race condition.
# Who cares!
my $cid = $pin->{cid};
say $cid;
return $c->pins->cid_count($cid)->then(sub ($count) {
if ($count == 1) {
@ -433,7 +422,7 @@ sub add($c) {
});
} else {
# TODO: read error and use appropriate response
say $res->body;
warn $res->body;
die "Failed to pin.";
}
})->then(sub($res) {