When running with a compositor the border of some applications (firefox,
chromium, zathura...) is not rendered correctly. Initializing the highest
significant bits of the color fixes it.
diff from Julien Blanchard (julien at typed-hole [dot] org); ok okan@
* refs/heads/master:
cycling fix: when no client is active, warp pointer to last active; from Walter Alejandro Iglesias.
whitespace
Fix spelling of some unused MWM hints; from Sean C. Farley.
Add group-last command that shows only the previously active group; ok okan
Allow bare numbers for key and mouse bindings; taken from similar support in other parse.y's; from Leon Fischer <lfischer@airmail.cc>.
sync parse.y changes from base; ok naddy@
Do not attempt to grab keys without a keycode; this incidentally allows XF86 keys support.
Spawn a window, maximize it in any way, move the cursor to a window border
that is not on the screen's edge and unmaximize again: While the window
goes back the cursor stays at the screen's edge, i.e. focus is lost to the
underlaying window.
Moving, resizing, tiling or snapping windows in any way always moves the
cursor along iff needed, e.g. using MS-[hjkl] to move a small window from
the center to the edge keeps the cursor within window borders -- no matter
what you do with the keyboard, focus stays on that window.
Make CM-f, CM-m, CM-equal and CMS-equal (default bindings) for toggling
full-screen mode, maximization, vertical maximization and horizontal
maximization of the current window drag the cursor along if needed as well.
OK okan kmos dv
* refs/heads/master:
Fixed memory leak in xu_get_strprop.
Prevent out of boundary write with configuration files in which too many quoted arguments are stored for other window managers.
Allow configuring a percentage window size of the master window during htile/vtile actions. From Uwe Werler, with a few manpage tweaks.
zap stray tabs
Instead of using _NET_ACTIVE_WINDOW on restart, use the pointer location to determine what client to set active. Reduces a round trip for every window.
Add support for SIGINT/SIGTERM.
Simplify conditional construct.
Trim event_mask to those that the root window actually needs.
No need to lookup current client early; move to right before it is needed.
Recommit 1.259, but now with TAILQ_FOREACH_SAFE.
Revert previous. Causes a crash as reported by Tom Murphy.
Simplify list markup.
Plug two memory leaks. Also get rid of a variable that is no longer necessary.
Remove ColormaskChange from event-mask since there's no event handler.
Unrelated style fixes, consistency changes and sorting, appropriate dosage/removal of wrappers, simplification of name queue, client cycle joins other kb/mb bound functions.
* refs/heads/master:
Allow the 'empty' group clients to be window-{h,v}tile'd.
Map ('5') and allow mod5mask (altgr) as a modifier.
add, then use, xvasprintf, checking for appropriate return.
Ensure the pointer stays within client bounds after a window 'snap' (to edge).
* refs/heads/master: (23 commits)
Check the atom type on propertynotify before iterating.
use screen_find() for xrandr crtc changes
Find the managed screen from the parent window for client_current().
Print window id in hex; while here, remove unnecessary newline.
Similar to keypress event, fetch the screen from the event root window in the buttonpress handler; bail if we don't manage the screen. Allows us to find the current client based on the screen/event root.
extend verbose logging for key/button events
[keypress event] turns out we've been checking the wrong window for a matching client thus always falling back to client_current(); while the current client is problaby right in most cases, use event's subwindow (not window) to find the client. Bail early if this event came to us from a screen we don't manage. This is result of us grabing all keybindings off the root window instead of selectively.
add parans for readibility
Teach client_current() to use a screen to find the current client instead of iterating over all (fallback if no screen provided for now). Initially convert trivial uses of client_current().
check cc->gc directly
zip extra lines
gc clientq inside groups, instead use the better maintained one per-screen
shuffle deck chairs: rename group actions to match intent for clarity
same thing as screen_find()
Separate out the menu window from the client resize/move geom window; in each case, create and destroy on-demand. Isolate more menu specific code.
fix a few misplaced (and misnamed) ewmh root window functions
_NET_WORKAREA needs ngroups, so screen_update_geometry() needs to come after conf_group().
simplify xftcolor config
Tie group number and name together during config.
Move the group index (desktop number) check to the only 2 callers that require checking due to ewmh.
...
* refs/heads/master:
Add 'group-close-[n]' action to close all windows within specified group.
simplify screen 'area' usage for initial client placement
restore order from before r1.248 (vtile/vtile containment changes).
Rename internal functions to delinate between client remove, delete and xproto delete; 'window-close' is now the proper action, but 'window-delete' as an alias will remain until more interesting changes require breaking configs.
Limit vtile/htile actions to clients fully within the screen of master client.
fix missing includes
* refs/heads/master:
Stop asking for events (NoEventMask) from menu window once done with the menu (we don't destroy it, only unmap).
Allow 'transientfor' clients to inherit group and bwidth either during init or via property notify events. Previously only the flags were set but nothing was in the path to apply said flags and/or bwidth. Required slight of re-orgnaization of client_init.
merge from base, from sashan@:
Use the original client border width to adjust initial placement of clients containing {P,US}Position requests where they are explicitly set to 'ignore' in cwmrc(5); clients are unaware that their border will be altered (removed in this case) when calcuating position and thus end up a factor of their original border width off once mapped by cwm(1). cwm(1) will essentially shift the client to the edge if the original request's position and border match.
via property notify events. Previously only the flags were set but nothing was
in the path to apply said flags and/or bwidth. Required slight of re-orgnaization
of client_init.
containing {P,US}Position requests where they are explicitly set to 'ignore' in
cwmrc(5); clients are unaware that their border will be altered (removed in
this case) when calcuating position and thus end up a factor of their original
border width off once mapped by cwm(1). cwm(1) will essentially shift the
client to the edge if the original request's position and border match.
Window offset noticed by at least Andre Stoebe via bugs@, and others since
(and likely before). Thanks!
* refs/heads/master: (28 commits)
Use screen's saved view instead of re-querying the server.
Slightly expand and expose verbose debugging.
add debugging for x events
Add a simple debug logging mechanism.
Simplification; use asprintf where appropriate now.
Use func attributes where appropriate.
Fix wins comparison declaration since it's unsigned from XQueryTree().
Generate name_to_func[] in a clean and readable fashion.
Shrink tier[] by one after removing matchname in r1.55.
If the requested group number is invalid, bail but don't kill cwm.
Quick fix: exit after a failed execvp in u_spawn instead; previously we did in u_exec, but the introduction of re-exec'ing the previous invocation of cwm if 'exec_wm' failed missed the 'exec' failing path. Will likely split out as a proper fix.
Only exec the fallback when in CWM_EXEC_WM state.
Typo, from Julien Steinhauser.
Convert menu-exec-wm from an abritrary exec menu, into a config-based menu from which one may configure (wm <name> <path_and_args>) (and choose) specific window managers to replace the running one. 'wm cwm cwm' is included by default.
As done for buttonrelease, work specific un-cycling and un-highlighting actions into the keyrelease event, only performing what's actually needed for each; should result in much fewer events against keyreleases. No intended behaviour change.
Merge group_toggle_membership_leave into the buttonrelease event and only do border work for a group/ungroup action.
add helper function client_show to bring together like actions for unhide/raise
Add support for re-exec'ing with SIGHUP; equivalent to the already built-in 'restart' function.
Use poll and XNextEvent to replace XNextEvent blocking inside the x11 event handler.
zap stray that snuck in
...
into the keyrelease event, only performing what's actually needed for each;
should result in much fewer events against keyreleases. No intended behaviour
change.
Additionally, like we do for group membership, grab the keyboard only when
required for cycling.
close to cwm's 'ignore'.
Roughly based on an initial diff from Walter Alejandro Iglesias, but with
support for both Atoms and without cwm-based bindings.
* refs/heads/master:
drop obsolete comment
Alter callbacks to take a struct instead of a growing number of arguments; greatly simplifies upcoming work.
Ensure clients stay within the viewable bounds on placement, even with empty borders; based on a patch from Vadim Vygonets.
Clean up, unify and accurately calculate edge distance with client move/resize actions, so as to not lose windows off the edge.
Switch bwidth type; unfortunately X11 is inconsistent.
* refs/heads/master:
The r1.36 menuq_add() conversion did this one wrong; fix by reverting to the original code which adds to resultentry list, as opposed to the wrong one in menuq_add(). Fixes crash noticed by at least Rickard Gustafsson.
Remove 'noresult' (and simplify) as it does nothing and makes the logic around it needless. History doesn't show what this might have been used for in future iterations.
search_match_path() isn't supposed to return anything.
Move queue init to caller so it's only called once in a few cases.
sort
Raise the previously focused window, instead of the previous window in the cycle list; seems to match behaviour of other wm's; from Walter Alejandro Iglesias.
For {h,v}tile, instead of keeping the master client's {h,v} geometry, expand it to %50 of the area, then fill in the remaining space with the other clients in the same group; from Gerrit Meyerheim.
* refs/heads/master:
Fix group hidden state when a client wants to be on all desktops on start; reported by Vadim Vygonets with diff, but another approach was taken.
Call client_resize instead of client_move after client_placecalc since the size may also change.
yosh
op
okan
kn
Leah Neukirchen
tim