* refs/heads/master:
cycling fix: when no client is active, warp pointer to last active; from Walter Alejandro Iglesias.
whitespace
Fix spelling of some unused MWM hints; from Sean C. Farley.
Add group-last command that shows only the previously active group; ok okan
Allow bare numbers for key and mouse bindings; taken from similar support in other parse.y's; from Leon Fischer <lfischer@airmail.cc>.
sync parse.y changes from base; ok naddy@
Do not attempt to grab keys without a keycode; this incidentally allows XF86 keys support.
* refs/heads/master:
Fixed memory leak in xu_get_strprop.
Prevent out of boundary write with configuration files in which too many quoted arguments are stored for other window managers.
Allow configuring a percentage window size of the master window during htile/vtile actions. From Uwe Werler, with a few manpage tweaks.
zap stray tabs
Instead of using _NET_ACTIVE_WINDOW on restart, use the pointer location to determine what client to set active. Reduces a round trip for every window.
Add support for SIGINT/SIGTERM.
Simplify conditional construct.
Trim event_mask to those that the root window actually needs.
No need to lookup current client early; move to right before it is needed.
Recommit 1.259, but now with TAILQ_FOREACH_SAFE.
Revert previous. Causes a crash as reported by Tom Murphy.
Simplify list markup.
Plug two memory leaks. Also get rid of a variable that is no longer necessary.
Remove ColormaskChange from event-mask since there's no event handler.
Unrelated style fixes, consistency changes and sorting, appropriate dosage/removal of wrappers, simplification of name queue, client cycle joins other kb/mb bound functions.
* refs/heads/master:
Allow the 'empty' group clients to be window-{h,v}tile'd.
Map ('5') and allow mod5mask (altgr) as a modifier.
add, then use, xvasprintf, checking for appropriate return.
Ensure the pointer stays within client bounds after a window 'snap' (to edge).
there's a window of time where an expose or enternotify event will get
generated for a lower client; use a hammer and drain events after keyboard
move/resize, until such a time that cwm doesn't warp the pointer. Behavior
noticed by kn.
ok kn@
* refs/heads/master:
Because cwm warps the pointer during a client move (to stay within the client), there's a window of time where an expose or enternotify event will get generated for a lower client; use a hammer and drain events after keyboard move/resize, until such a time that cwm doesn't warp the pointer. Behavior noticed by kn.
Fix regression from r1.107 (lost a return); kettenis@ pointed out the high potential for a use-after-free (true!) where kn@ ran into the regression using an app that actually exercised the XGrabPointer() failure path.
Add application section
command uses execvp(3) not execve(2)
Plug a memory leak in log_debug(); OK okan@
Handle _NET_WM_NAME changes.
* refs/heads/master: (23 commits)
Check the atom type on propertynotify before iterating.
use screen_find() for xrandr crtc changes
Find the managed screen from the parent window for client_current().
Print window id in hex; while here, remove unnecessary newline.
Similar to keypress event, fetch the screen from the event root window in the buttonpress handler; bail if we don't manage the screen. Allows us to find the current client based on the screen/event root.
extend verbose logging for key/button events
[keypress event] turns out we've been checking the wrong window for a matching client thus always falling back to client_current(); while the current client is problaby right in most cases, use event's subwindow (not window) to find the client. Bail early if this event came to us from a screen we don't manage. This is result of us grabing all keybindings off the root window instead of selectively.
add parans for readibility
Teach client_current() to use a screen to find the current client instead of iterating over all (fallback if no screen provided for now). Initially convert trivial uses of client_current().
check cc->gc directly
zip extra lines
gc clientq inside groups, instead use the better maintained one per-screen
shuffle deck chairs: rename group actions to match intent for clarity
same thing as screen_find()
Separate out the menu window from the client resize/move geom window; in each case, create and destroy on-demand. Isolate more menu specific code.
fix a few misplaced (and misnamed) ewmh root window functions
_NET_WORKAREA needs ngroups, so screen_update_geometry() needs to come after conf_group().
simplify xftcolor config
Tie group number and name together during config.
Move the group index (desktop number) check to the only 2 callers that require checking due to ewmh.
...
* refs/heads/master:
Add 'group-close-[n]' action to close all windows within specified group.
simplify screen 'area' usage for initial client placement
restore order from before r1.248 (vtile/vtile containment changes).
Rename internal functions to delinate between client remove, delete and xproto delete; 'window-close' is now the proper action, but 'window-delete' as an alias will remain until more interesting changes require breaking configs.
Limit vtile/htile actions to clients fully within the screen of master client.
fix missing includes
* refs/heads/master: (28 commits)
Use screen's saved view instead of re-querying the server.
Slightly expand and expose verbose debugging.
add debugging for x events
Add a simple debug logging mechanism.
Simplification; use asprintf where appropriate now.
Use func attributes where appropriate.
Fix wins comparison declaration since it's unsigned from XQueryTree().
Generate name_to_func[] in a clean and readable fashion.
Shrink tier[] by one after removing matchname in r1.55.
If the requested group number is invalid, bail but don't kill cwm.
Quick fix: exit after a failed execvp in u_spawn instead; previously we did in u_exec, but the introduction of re-exec'ing the previous invocation of cwm if 'exec_wm' failed missed the 'exec' failing path. Will likely split out as a proper fix.
Only exec the fallback when in CWM_EXEC_WM state.
Typo, from Julien Steinhauser.
Convert menu-exec-wm from an abritrary exec menu, into a config-based menu from which one may configure (wm <name> <path_and_args>) (and choose) specific window managers to replace the running one. 'wm cwm cwm' is included by default.
As done for buttonrelease, work specific un-cycling and un-highlighting actions into the keyrelease event, only performing what's actually needed for each; should result in much fewer events against keyreleases. No intended behaviour change.
Merge group_toggle_membership_leave into the buttonrelease event and only do border work for a group/ungroup action.
add helper function client_show to bring together like actions for unhide/raise
Add support for re-exec'ing with SIGHUP; equivalent to the already built-in 'restart' function.
Use poll and XNextEvent to replace XNextEvent blocking inside the x11 event handler.
zap stray that snuck in
...
which one may configure (wm <name> <path_and_args>) (and choose) specific
window managers to replace the running one. 'wm cwm cwm' is included by
default.
No objections and seems sensible to sthen.
into the keyrelease event, only performing what's actually needed for each;
should result in much fewer events against keyreleases. No intended behaviour
change.
Additionally, like we do for group membership, grab the keyboard only when
required for cycling.
* refs/heads/master:
Original idea from Dimitris Papastamos to move windows to corners a while ago; re-proposed by Julien Steinhauser with an updated diff. Apparently this was in the original calmnwm.
give command and group menus their own match callbacks
stash dir into conf since it'll be of use
organize this a bit better
spacing
re-proposed by Julien Steinhauser with an updated diff. Apparently this was in
the original calmnwm.
However, expand the original idea and let clients 'snap' to edges instead,
neatly allowing key bindings that snap to adjacent edges (i.e. corners) as
well. No default bindings assigned.
* refs/heads/master:
Revert r1.109 (Switch to XWindowEvent() pulling out events that match the mask *and* window.) of mousefunc.c. When a client destroys itself while we are moving or resizing it, XWindowEvent() blocks. Found the hard way by Anton Lazarov, and Lea°hNeukirchen found the right bit to revert - thanks! Reverting since the reason to switch from XMaskEvent was unclear.
*and* window.) of mousefunc.c. When a client destroys itself while we are
moving or resizing it, XWindowEvent() blocks. Found the hard way by Anton
Lazarov, and Lea°hNeukirchen found the right bit to revert - thanks! Reverting
since the reason to switch from XMaskEvent was unclear.
* refs/heads/master:
Use the key names from keysymdef.h in the default key bindings list for clarification.
remove extra parentheses
Pull over the remaining re-implemented window move/resize functions and create a wrapper so that the key and mouse based move/resize callbacks can be unified. This has already been done with other window operations and menus.
rename one function, matching others, to help upcoming change
* refs/heads/master:
Replace fgetln(3) with POSIX getline(3); inspired by brynet and Ingo.
fix a few WARNINGS (new sentence, new line and extraneous Pp macro) found with mandoc -Tlint
from src, by espie@: no need to generate y.tab.h if nothing uses it, set YFLAGS to nothing
* refs/heads/master:
drop obsolete comment
Alter callbacks to take a struct instead of a growing number of arguments; greatly simplifies upcoming work.
Ensure clients stay within the viewable bounds on placement, even with empty borders; based on a patch from Vadim Vygonets.
Clean up, unify and accurately calculate edge distance with client move/resize actions, so as to not lose windows off the edge.
Switch bwidth type; unfortunately X11 is inconsistent.
* refs/heads/master:
Ensure client stays inbound on key-based resize; based on logic existing in key-based client move; from Vadim Vygonets.
When a window has a user or program specified position, ensure the edge of the final position is at least viewable and warp'able by the difference of bwidth; prevents mapping windows completely off the virtual screen.
* refs/heads/master:
stray newlines
Add search_print_text(), a default callback for mi->print in menu_filter(). While here, normalize the remaining search_print_* argument paramters.
Consistent use of menuq_add for ssh menu.
Now that dim.{x,y} are available early, use them before requiring a MotionNotify event.
Set dim.{x,y} during client_init and update on resize, instead of (re)calculating only when applying hints.
'window-search' is spelled 'menu-window'; the former snuck in during the conversion('menu-window' already existed and was properlly documented); found the hard way by sthen@ while trying to convert.
Fold unbinding functions into one for each, key and mouse; plugs a leak when unbinding a mouse button bound to a command.
use the correct type
Tame the number of 'exec' and 'path' search_match wrappers. No functional change now, though more can likely go later, losing the (paritally complete or incomplete/broken) argument completion bits.
Switch ssh menu to search_match_text; like group/window/cmd menus, use only a substring match. The previous matching is only intended for the exec menus.
Change 'menu-window' to display all windows; then add 'menu-window-hidden' for the previous behaviour of 'menu-window'. 'menu-window' becomes the default binding; use 'bind-mouse "1" menu-window-hidden' to restore old behaviour for those who prefer.
Normalize bind function names, based on a few categories: window, group, menu and pointer.
Use an additional check with lstat(2) when d_type is unknown.
revert previous; upcoming changes will hopefully deal with these more naturally.
Add a wrapper based upon xevent handlers around client move/resize for key and mouse bindings.
Define callbacks, then default bindings.
Reorganize for upcoming changes.
Remove the (8) default bindings for pointer move since they conflict with default bindings for emacs, which wins; the feature remains and can be bound to whatever users wish with cwmrc(5).
yosh
okan
op
Leah Neukirchen
tim
Christian Neukirchen